Hello
On 6/3/2016 7:29 PM, Vincent Palatin wrote:
Do not shutdown the PHY if Wake-on-Lan is enabled, else it cannot wake
us up.
I do not understand why you need that.
This is done inside the PHY layer and it is tested on our platforms
he idea is: If the parent wants to Wake the system then the PHY should
not power-down.
Peppe
Signed-off-by: Vincent Palatin <vpala...@chromium.org>
---
drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
index 0cd3ecf..2e45e75 100644
--- a/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
+++ b/drivers/net/ethernet/stmicro/stmmac/dwmac-rk.c
@@ -534,6 +534,10 @@ static int rk_gmac_init(struct platform_device *pdev, void
*priv)
struct rk_priv_data *bsp_priv = priv;
int ret;
+ /* Keep the PHY up if we use Wake-on-Lan. */
+ if (device_may_wakeup(&pdev->dev))
+ return 0;
+
ret = phy_power_on(bsp_priv, true);
if (ret)
return ret;
@@ -549,6 +553,10 @@ static void rk_gmac_exit(struct platform_device *pdev,
void *priv)
{
struct rk_priv_data *gmac = priv;
+ /* The PHY was up for Wake-on-Lan. */
+ if (device_may_wakeup(&pdev->dev))
+ return;
+
phy_power_on(gmac, false);
gmac_clk_enable(gmac, false);
}
