On Fri, Jun 3, 2016 at 4:28 PM, David Miller <da...@davemloft.net> wrote:
> From: Cong Wang <xiyou.wangc...@gmail.com>
> Date: Wed, 1 Jun 2016 16:15:20 -0700
>
>> The police action is using its own code to initialize tcf hash
>> info, which makes us to forgot to initialize a->hinfo correctly.
>> Fix this by calling the helper function tcf_hash_create() directly.
>>
>> This patch fixed the following crash:
> ...
>> Fixes: ddf97ccdd7cb ("net_sched: add network namespace support for tc
>> actions")
>> Cc: Jamal Hadi Salim <j...@mojatatu.com>
>> Signed-off-by: Cong Wang <xiyou.wangc...@gmail.com>
>
> This adds a new warning, please resubmit with this fixed.
>
> net/sched/act_police.c: In function ‘tcf_act_police_locate’:
> net/sched/act_police.c:247:3: warning: ‘police’ may be used uninitialized in
> this function [-Wmaybe-uninitialized]
Oh, sure, my compiler didn't catch this.
I will send v2 tomorrow.
