Hi Andrew, > -----Original Message----- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent: 01 June 2016 18:42 > To: Pramod Kumar > Cc: Rob Herring; Pawel Moll; Mark Rutland; Ian Campbell; Kumar Gala; Catalin > Marinas; Will Deacon; Kishon Vijay Abraham I; David S. Miller; > devicet...@vger.kernel.org; Jon Mason; netdev@vger.kernel.org; linux- > ker...@vger.kernel.org; bcm-kernel-feedback-l...@broadcom.com; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v2 7/7] phy: Add Northstar2 PCI Phy support > > > +static int ns2_pci_phy_probe(struct mdio_device *mdiodev) { > > + struct device *dev = &mdiodev->dev; > > + struct phy_provider *provider; > > + struct ns2_pci_phy *p; > > + struct phy *phy; > > + > > + phy = devm_phy_create(dev, dev->of_node, &ns2_pci_phy_ops); > > + if (IS_ERR_OR_NULL(phy)) { > > + dev_err(dev, "failed to create Phy\n"); > > + return PTR_ERR(phy); > > + } > > https://www.mail-archive.com/linux-omap@vger.kernel.org/msg78030.html >
I've explored inside this API and see it never returning NULL. I'll replace IS_ERR_OR_NULL to IS_ERR. Thanks for pointing this out. > Andrew Regards, Pramod
