> -----Original Message----- > From: Bjørn Mork [mailto:bj...@mork.no] > Sent: Thursday, June 2, 2016 3:11 AM > To: Limonciello, Mario <mario_limoncie...@dell.com> > Cc: gre...@linuxfoundation.org; hayesw...@realtek.com; linux- > ker...@vger.kernel.org; netdev@vger.kernel.org; linux- > u...@vger.kernel.org; pali.ro...@gmail.com; anthony.w...@canonical.com > Subject: Re: [PATCH] r8152: Add support for setting MAC to system's > Auxiliary MAC address > > <mario_limoncie...@dell.com> writes: > > >> > +static u8 amac_ascii_to_hex(int c) { > >> > + if (c <= 0x39) > >> > + return (u8)(c - 0x30); > >> > + else if (c <= 0x46) > >> > + return (u8)(c - 0x37); > >> > + return (u8)(c - 0x57); > >> > +} > >> > > > > Sorry forgot to address this. > > > >> We really don't have such a function somewhere in the kernel already? > > > > There is a function in acpi/acpica/uthex.c that does this, but it > > doesn't seem to be used by anything outside of acpica so far. Would it be > OK style wise to #include " ../../acpi/acpica/acutils.h" from r8152.c? > > Makes me wonder where you looked.... You have hex_to_bin() and > hex2bin() in include/linux/kernel.h >
Thank you, I completely missed that. I wasn't looking for literals in my grepping. I'll use this instead. > You could look at usbnet_get_ethernet_addr() for an example of how to do > this properly. It's pretty close to this driver in the tree, and should be a > natural starting point before reinventing the wheel... > OK will do.
