On Wed, May 25, 2016 at 09:50:36AM -0700, Eric Dumazet wrote: > 1) mlx4_en_xmit() can increment priv->stats.tx_dropped, but this variable > is overwritten in mlx4_en_DUMP_ETH_STATS(). > > 2) This increment was not SMP safe, as a port might have many TX queues. > > Add a per TX ring tx_dropped to fix these issues. > > This is u32 as mlx4_en_DUMP_ETH_STATS() will add a 32bit field. > > So lets avoid bugs with SNMP agents having to cope with partial > overwraps. (One of these agents being bond_fold_stats()) > > Signed-off-by: Eric Dumazet <eduma...@google.com> > Reported-by: Willem de Bruijn <will...@google.com> > Cc: Eugenia Emantayev <euge...@mellanox.com>
this problem was bugging me as well. thank you for fixing it. Acked-by: Alexei Starovoitov <a...@kernel.org>
