On Friday 20 May 2016 12:32:23 Petko Manolov wrote:
> Guys, come on. This code is not dead. This code is executed every time an
> ethernet packet is received. It takes care of various error statistics. More
> importantly, it sends the actual (reported by the adapter) packet length to
> the
> network layer along with the packet.
>
> This patch removes skb_put() and netif_rx() calls and effectively kills the
> RX
> path. Not to mention that the driver was not even compiled before sending
> the
> patch upstream.
>
> The only sensible, although cosmetic, change would be to replace:
>
> if (!count || count < 4)
>
> with
>
> if (count < 4)
>
> even though GCC takes care and it optimizes away "!count" condition.
>
> Please revert this patch before Linus pulls from the network tree.
>
Agreed. I failed to check the commit that introduced the warning for
the more serious problem.
Please revert e00be9e4d0ff, it just makes no sense.
Arnd
