On Thu, 2016-05-19 at 09:08 -0700, Alexei Starovoitov wrote: > initially I thought that above line could have been qdisc_root_sleeping_lock() > but then realized that moving out ASSERT_RTNL makes more sense. Good call. > The only thing not clear to me is why '!defined(CONFIG_LOCKDEP)' ? > Just extra caution? I think should be fine without it.
I believe it is better to exercise this code path (using spinlock) even on 64bit kernel for kernels with LOCKDEP. This could avoid some hard to debug bugs occurring on 32bit builds.
