On Thu, 2016-05-19 at 13:36 +0800, Jason Wang wrote: > We used to check dev->reg_state against NETREG_REGISTERED after each > time we are woke up. But after commit 9e641bdcfa4e ("net-tun: > restructure tun_do_read for better sleep/wakeup efficiency"), it uses > skb_recv_datagram() which does not check dev->reg_state. This will > result if we delete a tun/tap device after a process is blocked in the > reading. The device will wait for the reference count which was held > by that process for ever. > > Fixes this by using RCV_SHUTDOWN which will be checked during > sk_recv_datagram() before trying to wake up the process during uninit. > > Fixes: 9e641bdcfa4e ("net-tun: restructure tun_do_read for better > sleep/wakeup efficiency") > Cc: Eric Dumazet <eduma...@google.com> > Cc: Xi Wang <x...@google.com> > Cc: Michael S. Tsirkin <m...@redhat.com> > Signed-off-by: Jason Wang <jasow...@redhat.com> > ---
Acked-by: Eric Dumazet <eduma...@google.com> Thanks !