> -----Original Message----- > From: David Miller [mailto:da...@davemloft.net] > Sent: 07 May 2016 20:09 > To: Paul Durrant > Cc: xen-de...@lists.xenproject.org; netdev@vger.kernel.org; Wei Liu > Subject: Re: [PATCH net-next 2/4] xen-netback: add control protocol > implementation > > From: Paul Durrant <paul.durr...@citrix.com> > Date: Thu, 5 May 2016 12:19:28 +0100 > > > +struct xenvif_hash_cache { > > + rwlock_t lock; > > You really don't want to lock on every SKB hash computation like > this, turn this into a spin lock for locking the write side and > use RCU locking for lookup and usage. >
Yes, that would be better. Will do. Cheers, Paul > THanks.
