> {
> struct mv88e6xxx_priv_state *ps = ds_to_priv(ds);
> int addr = mv88e6xxx_port_to_phy_addr(ps, port);
> - int ret;
> + int err;
>
> if (addr < 0)
> return 0xffff;
>
> +
We don't want an extra blank line. I'm surprised checkpatch did not
warn about this.
> mutex_lock(&ps->smi_mutex);
> - ret = _mv88e6xxx_phy_write(ps, addr, regnum, val);
> +
> + if (mv88e6xxx_has(ps, MV88E6XXX_FLAG_PPU))
> + err = _mv88e6xxx_phy_write_ppu(ps, addr, regnum, val);
> + else
> + err = _mv88e6xxx_phy_write(ps, addr, regnum, val);
> +
> mutex_unlock(&ps->smi_mutex);
> - return ret;
> +
> + return err;
Please don't rename ret to err. This patch is about phy reading and
writing, and i don't expect to see anything else here. It makes it
harder to review.
Andrew
