On Wed, May 4, 2016 at 3:31 PM, Arnd Bergmann <a...@arndb.de> wrote: > VXLAN can be disabled at compile-time or it can be a loadable > module while mlx5 is built-in, which leads to a link error: > > drivers/net/built-in.o: In function `mlx5e_create_netdev': > ntb_netdev.c:(.text+0x106de4): undefined reference to `vxlan_get_rx_port' > > This avoids the link error and makes the vxlan code optional, > like the other ethernet drivers do as well. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> > Link: https://patchwork.ozlabs.org/patch/589296/ > Fixes: b3f63c3d5e2c ("net/mlx5e: Add netdev support for VXLAN tunneling") > --- > I sent it originally on Feb 26 2016, but misread Saeed Mahameed's > reply as saying that he'd fix it up himself. The new version > should address the original comment. > ---
Hi Arnd, I didn't post a fix up since it is not needed anymore, see b7aade15485a ('vxlan: break dependency with netdev drivers') in net-next. The new issue is introduced due to : "net/mlx5: Kconfig: Fix MLX5_EN/VXLAN build issue" which was merged from net tree. Dave shouldn't have merged it into net-next, I explicitly asked him that in the cover letter. Maybe he missed it. I just checked and It is sufficient to only take the revert patch: [PATCH 1/3] Revert "net/mlx5: Kconfig: Fix MLX5_EN/VXLAN build issue" to net-next. Can you please confirm that with only the revert patch, you don't see the issue ?