On Thu, May 5, 2016 at 9:09 AM, Alexander Duyck <alexander.du...@gmail.com> wrote: > On Wed, May 4, 2016 at 7:59 PM, Alexander Duyck > <alexander.du...@gmail.com> wrote: >> On Wed, May 4, 2016 at 6:02 PM, Tom Herbert <t...@herbertland.com> wrote: >>> In several gso_segment functions there are checks of gso_type against >>> a seemingly abitrary list of SKB_GSO_* flags. This seems like an >>> attempt to identify unsupported GSO types, but since the stack is >>> the one that set these GSO types in the first place this seems >>> unnecessary to do. If a combination isn't valid in the first >>> place that stack should not allow setting it. >> >> You would think that was the case. The problem is I have already seen >> one issue with GUE allowing an unsupported combination of GRE_CSUM and >> UDP tunnels. > > I thought about this some more and it isn't as if the checks would > have caught this anyway as the GRE bits were being skipped over. I'd > say we can probably just drop all these checks and save ourselves the > space. So I retract my earlier comments against this specific patch > and will Ack it when we get the issues with the other patches in the > series resolved. > Wow, you sent this ten seconds before I hit send for a well crafted reply. :-)
Thanks, Tom > - Alex
