On Sat, Apr 30, 2016 at 06:58:04AM -0400, Jamal Hadi Salim wrote: > From: Lucas Bates <luc...@mojatatu.com> > > Signed-off-by: Lucas Bates <luc...@mojatatu.com> > Signed-off-by: Jamal Hadi Salim <j...@mojatatu.com>
Acked-by: Phil Sutter <p...@nwl.cc> Nit-picking on two things below, but merely as a hint - I don't think they need to be fixed before applying this. [...] > +.SH NAME > +IFE - encapsulate/decapsulate metadata > +.SH SYNOPSIS > +.in +8 > +.ti -8 > +.BR tc " ... " "action" > +.B "ife" The quotes around 'action' and 'ife' are not necessary. Furthermore, the two lines can be combined: > +.I DIRECTION ACTION > +.RB "[ " dst > +.IR DMAC " ] " > +.RB "[ " src > +.IR SMAC " ] " > +.RB "[ " type > +.IR TYPE " ] " > +.R "[ " This adds a trailing whitespace. Checkpatch.pl finds these things. ;) Thanks, Phil