On Thu, 2016-04-28 at 05:09 -0700, Eric Dumazet wrote:
> On Thu, 2016-04-28 at 11:04 +0200, Paolo Abeni wrote:
> > After the commit e09acddf873b ("ip_tunnel: replace dst_cache with generic
> > implementation"), a preemption debug warning is triggered on ip4
> > tunnels updating; the dst cache helper needs to be invoked in unpreemptible
> > context.
> >
> > We don't need to load the cache on tunnel update, so this commit fixes
> > the warning replacing the load with a dst cache reset, which is
> > preempt safe.
> >
> > Fixes: e09acddf873b ("ip_tunnel: replace dst_cache with generic
> > implementation")
> >
> > Reported-by: Eric Dumazet <eric.duma...@gmail.com>
> > Signed-off-by: Paolo Abeni <pab...@redhat.com>
> > ---
>
> Seems good to me, thanks.
>
> Note that the Fixes: tag should not be followed by a blank line.
> (And presumably no line wrap is necessary)
> It really is part of the standard set of tags.
> They should be grouped together.
Oops, I missed that points and checkpatch.pl did not help.
Thank you for the advice.
Paolo
