On 04/28/2016 07:18 AM, Roopa Prabhu wrote: > On 4/27/16, 9:18 AM, Nikolay Aleksandrov wrote: >> We can't allow more than one stats attribute which uses the local idx >> since the result will be a mess. This is a simple check to make sure >> only one is being used at a time. Later when the filter_mask's 32 bits >> are over we can switch to a bitmap. >> >> Signed-off-by: Nikolay Aleksandrov <niko...@cumulusnetworks.com> >> --- >> include/net/rtnetlink.h | 6 ++++++ >> net/core/rtnetlink.c | 17 +++++++++++++++-- >> 2 files changed, 21 insertions(+), 2 deletions(-) >> [snip] >> @@ -3570,6 +3578,11 @@ static int rtnl_stats_dump(struct sk_buff *skb, >> struct netlink_callback *cb) >> if (!filter_mask) >> return -EINVAL; >> >> + /* only one attribute which can save a local idx is allowed at a time */ >> + lidx_filter = filter_mask & IFLA_STATS_IDX_ATTR_MASK; >> + if (lidx_filter && !is_power_of_2(lidx_filter)) >> + return -EINVAL; >> + >> > instead of introducing the restriction at this level, is it possible to use > two args for this > like below and avoid the restriction ? > cb->args[2] = current filter being processed > cb->args[3] = private filter idx (your lidx) >
So to allow having any number of idx saving callbacks ? I think this will introduce more complexity as we'll have to differentiate between 3 types of filters now - non-idx saving, idx saving but passed and current idx saving attribute. We will dump the non-idx saving on each call, but then skip some and continue dumping.. I'll give it a try to see how it looks. :-) Thanks, Nik
