On Mon, 25 Apr 2016 11:00:35 -0700, pravin shelar wrote: > On Sun, Apr 24, 2016 at 4:00 AM, Jiri Benc <jb...@redhat.com> wrote: > > The IFLA_GRE_REMOTE attribute does not make sense together with collect > > metadata and is ignored in such case. However, iproute2 always sets it; it > > will be zero if there's no remote address specified on the command line. > > > > Remove the check for non-zero IFLA_GRE_REMOTE when collect medata flag is > > set. > > > Rather than cover up in ip_gre kernel module, why not just fix > iproute2 to set the attribute correctly?
Well, who defines "correctly"? :-) I can do that, it really doesn't matter. One way or the other, the result will be the same. I'll move this to iproute2 in v3. Jiri
