On 4/25/16 1:26 PM, David Miller wrote:
From: David Ahern <d...@cumulusnetworks.com> Date: Thu, 21 Apr 2016 20:56:12 -0700Dave: I realize this goes against your preference to keep routes cached on a down but this patch really emphasizes my point of all the dark corners to be handled.I've learned my lesson, I never should have put the original patch in to begin with. And you're so sloppy here, you didn't even bother adding a Fixes: tag. The patch at the root of all of this has terrible semantics, and it's added tons of regressions. All of which goes against our most basic principles. I've been patient enough, but I've now reverting everything, sorry. It's unfortunate if you have things which depend upon this, but too bad. This change has been extremely disruptive for a lot of people, including me. You're going to have to work really hard to ever get me to consider applying patches which do this again.
It's unfortunate you want to take that action. Last week I came across a prior attempt by Stephen to do this same thing -- keep IPv6 addresses. That prior attempt was reverted by commit 73a8bd74e261. Cumulus, Brocade, and others clearly want this capability.
You have made many comments about the pains due to differences between IPv4 and IPv6. I deal with those pains daily. It takes time to close those differences and unfortunately there have been and will be bumps in the road. If you look back at the commits on top of the original I responded quickly to the 1 bug report from Andrey and the rest of the followups have come from me (or the delta from Mike at Brocade) which are a result of our range of testing with this sysctl enabled.
