On Thu, 13 Apr 2006 22:45:34 +1000 Herbert Xu <[EMAIL PROTECTED]> wrote:
> On Wed, Apr 12, 2006 at 03:42:14PM -0700, Stephen Hemminger wrote: > > By inspection, the clip idle timer code is racy on SMP. > > Here is a safe version of timer management. > > Untested, I don't have ATM hardware. > > Good catch Stephen. > > > - if (start_timer == 0) > > - del_timer(&idle_timer); > > + del_timer_sync(&idle_timer); > > I don't think this is enough though since this timer is one of those > self-rescheduling timers. You need to provide some sort of a flag > for it to stop scheduling itself and synchronise it properly. Arp and neighbor table have the same rescheduling bug. > Of course this is an existing bug but we might as well squash it > before we forget about it. > > Cheers, - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
