From: David Miller <da...@davemloft.net>
Date: Thu, 21 Apr 2016 14:04:54 -0400 (EDT)
> From: Saeed Mahameed <sae...@mellanox.com>
> Date: Tue, 19 Apr 2016 15:33:42 +0300
>
>> Upon ethtool request to set speed to 0 we handle it as a special request
>> to reset link modes to Device's defaults.
>>
>> Fixes: f62b8bb8f2d3 ("net/mlx5: Extend mlx5_core to support ConnectX-4
>> Ethernet functionality")
>> Signed-off-by: Saeed Mahameed <sae...@mellanox.com>
>
> Please don't try to sneak things like this into the patches you submit.
Also, this patch series doesn't even compile:
[davem@dhcp-10-15-49-210 net]$ make -s -j16
Makefile:679: Cannot use CONFIG_KCOV: -fsanitize-coverage=trace-pc is not
supported by compiler
DESCEND objtool
drivers/infiniband/hw/mlx5/main.c: In function ‘mlx5_query_hca_port’:
drivers/infiniband/hw/mlx5/main.c:721:32: error: passing argument 2 of
‘mlx5_query_port_max_mtu’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
mlx5_query_port_max_mtu(mdev, &max_mtu, port);
^
In file included from drivers/infiniband/hw/mlx5/main.c:45:0:
include/linux/mlx5/port.h:58:6: note: expected ‘u16 * {aka short unsigned int
*}’ but argument is of type ‘int *’
void mlx5_query_port_max_mtu(struct mlx5_core_dev *dev, u16 *max_mtu, u8 port);
^
drivers/infiniband/hw/mlx5/main.c:725:33: error: passing argument 2 of
‘mlx5_query_port_oper_mtu’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
mlx5_query_port_oper_mtu(mdev, &oper_mtu, port);
^
In file included from drivers/infiniband/hw/mlx5/main.c:45:0:
include/linux/mlx5/port.h:59:6: note: expected ‘u16 * {aka short unsigned int
*}’ but argument is of type ‘int *’
void mlx5_query_port_oper_mtu(struct mlx5_core_dev *dev, u16 *oper_mtu,
^
cc1: some warnings being treated as errors
scripts/Makefile.build:291: recipe for target
'drivers/infiniband/hw/mlx5/main.o' failed
make[4]: *** [drivers/infiniband/hw/mlx5/main.o] Error 1
