Hi David,
On Wed, Apr 20, 2016, at 03:11, David Miller wrote:
> From: Hannes Frederic Sowa <han...@stressinduktion.org>
> Date: Wed, 20 Apr 2016 03:06:13 +0200
>
> > On Wed, Apr 20, 2016, at 02:27, David Miller wrote:
> >> From: Hannes Frederic Sowa <han...@stressinduktion.org>
> >> Date: Mon, 18 Apr 2016 21:19:41 +0200
> >>
> >> > This patchset removes the dependency of network drivers on vxlan or
> >> > geneve, so those don't get autoloaded when the nic driver is loaded.
> >> >
> >> > Also audited the code such that vxlan_get_rx_port and geneve_get_rx_port
> >> > are not called without rtnl lock.
> >>
> >> In net-next, the 'qed' driver has tunneling offload support too.
> >> Don't you need to update this series to handle that driver as
> >> well?
> >
> > I audited qede as well:
> >
> > qede calls {vxlan,geneve}_get_rx_port only from ndo_open which isn't
> > reused anywhere else in the driver, only from ndo_open, which holds
> > rtnl_lock also. Thus the driver is safe and doesn't need a change.
>
> I'm talking about your final patches which elide the dependencies.
could you look at this again? If you have further feedback I am happy to
incooperate those.
Thank you,
Hannes
