On 4/19/16, 3:49 PM, David Miller wrote: > From: Roopa Prabhu <ro...@cumulusnetworks.com> > Date: Tue, 19 Apr 2016 12:05:00 -0700 > >> ok, will do. one thing though, for GETSTATS, if I need a pad >> attribute like IFLA_PAD, I will need to add a new stats attribute >> IFLA_STATS_PAD and burn a bit for it in filter_mask too. In which >> case, I am wondering if we should live with the copy. I will take >> any suggestions here. > I don't think the copy is appropriate, especially if the existing full > link state dump gets away without it. We're adding this facility for > performance reasons after all. > > You have several options to avoid wasting filter mask space. For > example, you could use IFLA_STATS_UNSPEC, which should be OK since > only new applications will use these. > > Or you could make IFLA_STATS_PAD the first attribute, and define the > filter mask as relative to it. Ie. IFLA_STATS_LINK_64 uses bit > (IFLA_STATS_LINK_64 - IFLA_STATS_PAD), etc. ok ack, makes sense.
thanks, Roopa
