On Mon, 2016-04-11 at 16:19 -0700, Cong Wang wrote: > My point is, for example, in OOM case, we don't know processin > more SKB would make it better or worse. Maybe we really need to > check the error code to decide to continue to exit?
Really, given this bug has been there for a long time (v3.18 ???), I doubt it matters. Nothing can tell that following packets in the qdisc need any transformation, and memory allocations. So I would just fix the bug in the simplest way. __qdisc_run() has all the checks needed to yield when needed (if (quota <= 0 || need_resched())) , no need to add more complexity there.
