> -----Original Message----- > From: Jesse Gross [mailto:je...@kernel.org] > Sent: Saturday, April 09, 2016 9:36 PM > To: Manish Chopra <manish.cho...@qlogic.com> > Cc: David Miller <da...@davemloft.net>; netdev <netdev@vger.kernel.org>; > Ariel Elior <ariel.el...@qlogic.com>; Yuval Mintz <yuval.mi...@qlogic.com> > Subject: Re: [PATCH net-next 1/6] net: Make vxlan/geneve default udp ports > public > > On Sat, Apr 9, 2016 at 10:17 AM, Manish Chopra <manish.cho...@qlogic.com> > wrote: > > Rationale behind this change is that with some OVS configuration > > UDP ports doesn't get notified to the driver using > > .ndo_[add|del]_vxlan_port. So for the driver to work with > > these specific ports in that environment we need to have them configured > > on adapter by default for the required hardware offload support. > > I think you are referring to old out of tree code - no version of > upstream OVS does this. In addition, any old code won't work against > the new kernels that would include this driver update anyways so there > won't be a benefit in any case. > > Please just use the normal registration mechanism that is already > exposed. I also noticed that in the Geneve case you aren't currently > registering for port notifications and just using the assigned port > number in all cases, which isn't right.
In the past I have tried openvswitch release package [V2.4.0] from openvswitch.org http://openvswitch.org/releases/ I have tried configuring ovs there on some redhat 7.x kernel with above mentioned package utility "ovs-vsctl" where ports were not notified to drivers. Till earlier versions of openvswitch package [V2.3.2] - It was fine and UDP ports were used to be notified to the driver I thought that the same [No port config notification to the drivers] problem would be with latest upstream OVS, isn't it ? which is why configuration of at least default ports is done by default in drivers. For upstream OVS, is there any other openvswitch package used ? Can't the above release package be used over net-next/upstream kernel ? If latest OVS notifies to configure UDP ports to the driver - I would simply skip default ports configuration by default and instead use .ndo_[add|del]_xxxx for both vxlan and geneve. Thanks, Manish
