On Sat, 2016-04-09 at 11:19 -0400, Jamal Hadi Salim wrote: > On 16-04-09 01:16 AM, Eric Dumazet wrote: > > > > > Lots of holes in this structure... > > > > > > > I may have mentioned to you that there is 8 bit hole in tcp_info too ;-> > (above tcpi_rto). Adding an 8 bit explicit pad seems useful > since it is already in the wild. I was going to send the patch after > netdev11 but forgot.
Well, once a hole is there, nothing we can do really, because of compatibility with old kernels / old binaries. But when a _new_ structure is defined, this is the time where we can ask for doing sensible things ;)