On April 8, 2016 10:06:40 PM PDT, Eric Dumazet <eric.duma...@gmail.com> wrote:
>From: Eric Dumazet <eduma...@google.com>
>
>By using napi_complete_done(), we allow fine tuning
>of /sys/class/net/ethX/gro_flush_timeout for higher GRO aggregation
>efficiency for a Gbit NIC.
>
>Check commit 24d2e4a50737 ("tg3: use napi_complete_done()") for
>details.
>
>Signed-off-by: Eric Dumazet <eduma...@google.com>
>Cc: Petri Gynther <pgynt...@google.com>
>Cc: Florian Fainelli <f.faine...@gmail.com>
Acked-by: Florian Fainelli <f.faine...@gmail.com>
Along the same line of changes, we could use napi_schedule_irqoff since NAPI is
always scheduled from ISR context.
>---
> drivers/net/ethernet/broadcom/genet/bcmgenet.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>index f7b42b9fc979..e823013d3125 100644
>--- a/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>+++ b/drivers/net/ethernet/broadcom/genet/bcmgenet.c
>@@ -1735,7 +1735,7 @@ static int bcmgenet_rx_poll(struct napi_struct
>*napi, int budget)
> work_done = bcmgenet_desc_rx(ring, budget);
>
> if (work_done < budget) {
>- napi_complete(napi);
>+ napi_complete_done(napi, work_done);
> ring->int_enable(ring);
> }
>
--
Florian
