David S. Miller <[EMAIL PROTECTED]> wrote: > From: Zach Brown <[EMAIL PROTECTED]> > Date: Fri, 07 Apr 2006 16:59:01 -0700 > >> b) Just calculate the hashes under the lock, we're already doing lots of >> work there anyway. > > I think this is the best way to go. Then we don't need to think > about it, and frankly I think the "recheck hash rnd after getting > lock" idea would turn out to be more expensive :)
Agreed. We should also fix up ip_frag_create/ip_frag_intern by getting rid of the hash argument and recomputing it in ip_frag_intern. Thanks, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html