I don't think ip6_sk_update_pmtu() is a good place to put it as all it does is to call ip6_update_pmtu(). And ip6_update_pmtu() does the route lookup and call __ip6_rt_update_pmtu. We can put it in ip6_update_pmtu(). But that still means we need to pass sk to ip6_update_pmtu() and I don't think it makes any difference compared to the current fix.
Thanks. Wei On Fri, Mar 18, 2016 at 11:10 AM, Cong Wang <xiyou.wangc...@gmail.com> wrote: > On Fri, Mar 18, 2016 at 10:45 AM, Wei Wang <wei...@google.com> wrote: >> Thanks all for the comments. >> >> Cong, you are right that for ipv6, the code does not take care of updating >> sk_dst_cache entry like Ipv4. And this patch is updating the entry by >> calling ip6_dst_store() to achieve similar functionality as Ipv4. > > My question is why not updating ip6_sk_update_pmtu() to sync with ipv4?
