Hello, On Fri, Mar 18, 2016 at 08:31:20PM +0100, Mason wrote: > On 18/03/2016 20:12, Uwe Kleine-König wrote: > > > On Fri, Mar 18, 2016 at 04:56:21PM +0100, Sebastian Frias wrote: > > > >> What would you think of making at803x_link_change_notify() print a > >> message every time it should do a reset but does not has a way to do it? > > > > Then this question is obsolete because the device doesn't probe. > > I don't understand this statement. > > What does it mean for a question to be obsolete?
If the driver doesn't probe because it cannot control the reset line, you don't need to think about how it should behave in at803x_link_change_notify without control of the reset line, because this code isn't reached then. Best regards Uwe -- Pengutronix e.K. | Uwe Kleine-König | Industrial Linux Solutions | http://www.pengutronix.de/ |