> > +.B ethtool \-I|\-\-phy-statistics > > +.I devname > > +.HP > > -I isn't a useful mnemonic, so I will drop the short option altogether.
It was the best i could come up with. -P would of been nice, since we have -S for MAC statistics, but that is taken. PHY sounds a bit like I, so why not. But i'm O.K. for -I to be dropped. > > + /* todo - pretty-print the strings per-driver */ > > + fprintf(stdout, "PHY statistics:\n"); > > + for (i = 0; i < n_stats; i++) { > > + fprintf(stdout, " %.*s: %llu\n", > > + ETH_GSTRING_LEN, > > + &strings->data[i * ETH_GSTRING_LEN], > > + stats->data[i]); > > + } > > + free(strings); > > + free(stats); > > + > > + return 0; > > +} > > This is basically a copy-paste of do_gstats() so they should be merged > into one function. O.K, i can do that. Andrew