Re: [PATCH net-next V2 01/10] net/flower: Introduce hardware offload support

[Amir Vadai"]

On Thu, Mar 03, 2016 at 12:30:33PM -0500, David Miller wrote:
> From: Amir Vadai <a...@vadai.me>
> Date: Thu,  3 Mar 2016 16:55:51 +0200
> 
> > @@ -454,11 +501,13 @@ static int fl_change(struct net *net, struct sk_buff 
> > *in_skb,
> >                  u32 handle, struct nlattr **tca,
> >                  unsigned long *arg, bool ovr)
> >  {
> > +   struct net_device *dev = tp->q->dev_queue->dev;
> >     struct cls_fl_head *head = rtnl_dereference(tp->root);
> 
> This variable is not used.
> 
> And the compiler warns about this, and because of this I am pretty sure you
> aren't looking at the compiler output while testing your builds which is a
> big no-no.
My bad. I did a last minute change that left this variable and somehow
missed the warning (though I did compile and test it).
Will fix for v3