On Mon, Mar 06, 2006 at 04:44:23PM +0100, Jiri Benc wrote:
> This patch removes "iwmode" variable (local->conf.mode) shared by all
> interfaces. Instead, every interface has its own type (STA/IBSS/AP/WDS).
> Index: dscape/include/net/d80211.h
> ===================================================================
> --- dscape.orig/include/net/d80211.h 2006-03-06 13:33:02.000000000 +0100
> +++ dscape/include/net/d80211.h 2006-03-06 14:10:07.000000000 +0100
> @@ -242,8 +242,6 @@ struct ieee80211_conf {
> int freq; /* MHz */
> int channel_val; /* hw specific value for the channel */
>
> - int mode; /* IW_MODE_ */
> -
This breaks bcm43xx-d80211 build. Do you happen to have a patch to fix
it? At least the experimental branch of your dscape.git seemed to show
the same issue:
CC [M] drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.o
drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c: In function
‘bcm43xx_net_config’:
drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c:4412: error: ‘struct
ieee80211_conf’ has no member named ‘mode’
drivers/net/wireless/bcm43xx-d80211/bcm43xx_main.c:4413: error: ‘struct
ieee80211_conf’ has no member named ‘mode’
The same issue showed up with our low-level driver. How was the
low-level driver supposed to get this information with this change?
d80211 part is likely fine, since it has the interface type available
like you mentioned, but I don't think that this is available to
low-level drivers(?). In other words, keeping this "int mode" in struct
ieee80211_conf may be useful even if we change d80211 to do something
else internally.
Which driver did you use to test these changes? I have now successfully
tested both client and AP modes with bcm43xx_d80211 and Devicescape
driver for Atheros cards prior to applying these 13 changes. I would
like to verify that the new changes work properly before they are
applied into the wireless-2.6 tree. I can change our code easily, but I
would rather not touch bcm43xx_d80211 code to avoid any problems in
keeping the reverse engineered implementation clean as far as use of
proprietary information is concerned.
--
Jouni Malinen PGP id EFC895FA
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
