On Thursday 09 March 2006 09:06, Ravikiran G Thirumalai wrote: > On Wed, Mar 08, 2006 at 04:32:58PM -0800, Andrew Morton wrote: > > Ravikiran G Thirumalai <[EMAIL PROTECTED]> wrote: > > > > > > On Wed, Mar 08, 2006 at 03:43:21PM -0800, Andrew Morton wrote: > > > > Benjamin LaHaise <[EMAIL PROTECTED]> wrote: > > > > > > > > > > I think it may make more sense to simply convert local_t into a long, > > > > > given > > > > > that most of the users will be things like stats counters. > > > > > > > > > > > > > Yes, I agree that making local_t signed would be better. It's > > > > consistent > > > > with atomic_t, atomic64_t and atomic_long_t and it's a bit more > > > > flexible. > > > > > > > > Perhaps. A lot of applications would just be upcounters for statistics, > > > > where unsigned is desired. But I think the consistency argument wins > > > > out. > > > > > > It already is... for most of the arches except x86_64. > > > > x86 uses unsigned long. > > Here's a patch making x86_64 local_t to 64 bits like other 64 bit arches. > This keeps local_t unsigned long. (We can change it to signed value > along with other arches later in one go I guess)
I already did that change in my tree (except it's currently unsigned long as Andrew Indicated) -Andi > - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
