On Thu, Feb 09, 2006 at 05:19:45PM -0500, John W. Linville wrote: > Drivers using mii_check_media (via-rhine in particular) and also > forcing link parameters with ethtool can reach a state where the link > goes down and never comes back up. This is because mii_check_media > short-circuits early if mii->force_media != 0. This was discussed > in a couple of past threads, one of which is available here: > > http://www.ussg.iu.edu/hypermail/linux/kernel/0508.3/0670.html > > The patch moves the force_media check to below the carrier status > check. This allows the link state to show correctly, while avoiding > the check of link parameters. >
I sent almost the same patch because of the same reasons about a year ago, see http://oss.sgi.com/projects/netdev/archive/2005-02/msg00648.html so I would vote for this patch too. Acked-by: Steffen Klassert <[EMAIL PROTECTED]> > Signed-off-by: John W. Linville <[EMAIL PROTECTED]> > --- - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
