From: FUJITA Tomonori <[EMAIL PROTECTED]> Subject: Re: [PATCH] Packet socket: fix for 64-bit kernel and 32-bit userland Date: Wed, 08 Feb 2006 14:59:06 +0900
> From: "David S. Miller" <[EMAIL PROTECTED]> > Subject: Re: [PATCH] Packet socket: fix for 64-bit kernel and 32-bit userland > Date: Tue, 07 Feb 2006 21:48:02 -0800 (PST) > > > From: FUJITA Tomonori <[EMAIL PROTECTED]> > > Date: Wed, 08 Feb 2006 14:41:41 +0900 > > > > > From: "David S. Miller" <[EMAIL PROTECTED]> > > > Subject: Re: [PATCH] Packet socket: fix for 64-bit kernel and 32-bit > > > userland > > > Date: Tue, 07 Feb 2006 21:36:06 -0800 (PST) > > > > > > > > tpacket_hdr structure includes 'unsigned long' though kernel and > > > > > userland shares it in the mmapped ring buffer. > > > > > > > > > > Seems it would be better to fix all data structures in the header file > > > > > than fixing only tpacket_hdr structure. > > > > > > > > > > Signed-off-by: FUJITA Tomonori <[EMAIL PROTECTED]> > > > > > Signed-off-by: Mike Christie <[EMAIL PROTECTED]> > > > > > > > > You broke 64-bit userland by changing that "unsigned long" > > > > to a __u32. > > > > > > You mean that currently it's broken in 64-bit kernel and 32-bit > > > userland anyway so use __u64 instead of __u32? > > > > I mean that "unsigned long" is 64-bit in a 64-bit kernel, and thus > > your changes break packet mmap() ringer buffers for native 64-bit > > binaries. > > I see. The following patch is OK? Sorry. seems I don't see that at all. Is there any good way to solve this problem? - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
