On Tue, 2006-01-31 at 17:07 -0800, David S. Miller wrote: > Sun GEM's die with your recent sungem driver changes. > > I'm talking about: > > [SUNGEM]: Make PM of PHYs more reliable (#2) > > On my latest laptop, I've had occasional PHY dead on wakeup from > sleep... the PHY would be totally unresponsive even to toggling the hard > reset line until the machine is powered down... Looking closely at the > code, I found some possible issues in the way we setup the MDIO lines > during suspend along with slight divergences from what Darwin does when > resetting it that may explain the problem. That patch change these and > the problem appear to be gone for me at least... I also fixed an mdelay > -> msleep while I was at it to the pmac feature code that is called > when toggling the PHY reset line since sungem doesn't call it in an > atomic context anymore. > > Signed-off-by: Benjamin Herrenschmidt <[EMAIL PROTECTED]>b > Signed-off-by: David S. Miller <[EMAIL PROTECTED]> > > For example, clearing all of those extra bits in gem_init_phy() and > forcing MIF_CFG_MDI0, PCS_DMODE_MGM in PCS_DMODE and > MAC_XIFCFG_OE in MAC_XIFCFG have lots of non-trivial consequences.
Ok, I'll look into it... > Forcefully clearing mifcfg to zero in gem_stop_phy() is asking for > a lot of trouble as well. Hrm... I didn't think gem_stop_phy() code path would ever be called on the sparc setup.... I'll dbl check. > I'm therefore going to revert this and ask that you work on these > changes in a systematic way, piece by piece, and run them each > through me so that we don't break the driver for Sun chips. > > So please work with me on this, thanks. Sure. Best might be to just put some of these in if (apple chip) though... I'll have a second go at the patch later this week hopefully (with baby just born I'm a bit scarse on spare time ...) Cheers, Ben. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
