On Tuesday 31 January 2006 01:09, John Heffner wrote: > David S. Miller wrote: > > From: John Heffner <[EMAIL PROTECTED]> > > Date: Tue, 06 Dec 2005 14:42:53 -0500 > > > >>I'd like to get a few people at least to look this over, and maybe give > >>it a try. One remaining item to consider is how best to cache the state > >>between connections. Are there any major concerns or reservations about > >>this approach, or the patch itself? > > > > I like this code, and the idea conceptually. > > > > I'm a little leery of turning it on by default though, at least > > initially. > > > > However I'm fine with it being in there, in it's current state. > > So can you do two things for me? > > > > 1) Get rid of the debugging printk()'s
I would suggest to replace them with statistic counters for netstat -s > > 2) Have the sysctl off by default > > > > and then I'll happily at this in for net-2.6.17 > > Sure thing. >From reading the patch it seems to have quite a lot of duplicated code with the output path in tcp_mtu_probe. Can't you consolidate this a bit more? Also if()s with 5 line conditions and magic numbers are always somewhat suspicious. Are you sure the checksum handling is correct? Also we're trying to get away from the giant inlines in tcp.h, so better move the new functions you add somewhere else out of line. -Andi - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
