On 1/25/06, Olaf Kirch <[EMAIL PROTECTED]> wrote: > On Wed, Jan 25, 2006 at 10:02:40AM +0100, Olaf Kirch wrote: > > I'm not sure what the right fix would be. e100_resume would probably > > have to call e100_alloc_cbs early on, while e100_up should avoid > > calling it a second time if nic->cbs_avail != 0. A tentative patch > > for testing is attached. > > Reportedly, the patch fixes the crash on resume.
Cool, thanks for the research, I have a concern about this however. its an interesting patch, but it raises the question why does e100_init_hw need to be called at all in resume? I looked back through our history and that init_hw call has always been there. I think its incorrect, but its taking me a while to set up a system with the ability to resume. everywhere else in the driver alloc_cbs is called before init_hw so it just seems like a long standing bug. comments? anyone want to test? i compile tested this, but it is untested.
e100_resume_no_init.diff
Description: Binary data
