On Tue, Jan 17, 2006 at 07:17:55PM +0100, Roger While wrote: > I am going to NACK this. > Two reasons : > 1) Unless we are patching different trees, it appears > the dev_kfree_skb at label drop_free got missed.
http://marc.theaimsgroup.com/?l=linux-netdev&m=113629395408219&w=2 According to Patrick McHardy, the other dev_kfree_skb change is no longer required. Perhaps Patrick will comment? > 2) I still do not understand this. Quote from the definition > of dev_kfree_skb_irq - > > /* Use this variant when it is known for sure that it > * is executing from interrupt context. > */ > > This patch is within the (hard)transmit path called from the > upper layers. I do not see any other driver doing this in the > hard transmit path. > Can we really get this in IRQ context ? > If, for any reason, that is so then we should use > dev_kfree_skb_any. > (Or I am being particularly thick) The patch has been merged. If it is wrong, let's have another patch and discuss what needs to happen. John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
