On Tue, 17 Jan 2006 14:55:10 -0800 (PST)
"David S. Miller" <[EMAIL PROTECTED]> wrote:

> From: Andi Kleen <[EMAIL PROTECTED]>
> Date: Tue, 17 Jan 2006 21:42:38 +0100
> 
> > On Tuesday 17 January 2006 21:31, jamal wrote:
> > 
> > > the TIPC tree has been open for months now for review. 
> > 
> > That is not how Linux code review works - the code is supposed to get posted
> > to the appropiate mailing lists so that people can go over it.
> > Reviewers normally don't hunt for random websites to look at code there.
> 
> I agree with Andi, TIPC should have been submitted as a set of
> patches or a pointer to such, on netdev before going in.
> 
> I take the blame for this, as I didn't enforce this procedure for the
> TIPC folks and I definitely should have.
> 
> So let's clean it up and I'll be more mindful to not sidestep this in
> the future.
> 
> Andi, thanks for calling a spade a spade.  It definitely was in this
> case.  TIPC went through the back door and that's totally
> unacceptable.

Also, let's work with the current code. It is a lot easier to let others
clean it up, if the changes are against the mainline (or -mm) rather than
having to send it off to get put into yet another git repo.

-- 
Stephen Hemminger <[EMAIL PROTECTED]>
OSDL http://developer.osdl.org/~shemminger
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to