jamal wrote:
On Fri, 2006-13-01 at 18:16 +0100, Thomas Graf wrote:
* Patrick McHardy <[EMAIL PROTECTED]> 2006-01-12 06:25
In the last case in prio_classify (band < q->bands) the band
is returned directly. This could come from attached filters
or from skb->priority. Its still not a fix since all bands
have at least noop-qdiscs attached to them, just a semantic
change which IMO makes sense.
I agree with Patrick, this patch makes perfect sense to although
the description is a bit misleading.
"perfect sense" is too strong. It is more fit to "grey area"
The policy comes from user space. The kernel is supposed to be dumb,
it just implements the mechanisms. If you tell the kernel
"here are 4 queues but i only want you to send packets to the
first 3" and then somehow a packet arrives for queue 4 then dammit,
the kernel has a right to throw it hard on the floor.
Well, part of the mechanism is manuall classification without
the priomap using filters or skb->priority. So I disagree with
this statement.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
