On Tue, 2006-01-03 at 21:22 -0800, David S. Miller wrote: > From: Tom Young <[EMAIL PROTECTED]> > Date: Wed, 04 Jan 2006 14:23:47 +1100 > > > Vegas' slow start was only adding one MSS per RTT rather than one for > > every ack. Slow start behavior should now match Reno. > > > > Signed-off-by: Thomas Young <[EMAIL PROTECTED]> > > Your email client has corrupted the spacing and tabbing in the patch, > please fix that. > > I feel that half of the patches I review have this problem. So I go > through the effort of reviewing someone's work only to find that their > patch doesn't even apply. It's bordering on rediculious :-/ > > Folks, if you don't know if your setup is ok or not, send yourself an > email with the patch in it and try to apply it yourself. > >
That it has. I'm really sorry about that. In this case it was my fault rather than the client (copying from an xterm). I guess I'm just coming out of slow start myself after the holiday lull. Please find the non-abomination version of the patch below. Sorry for the noise. Thanks, Tom Vegas' slow start was only adding one MSS per RTT rather than one for every ack. Slow start behavior should now match Reno. Signed-off-by: Thomas Young <[EMAIL PROTECTED]> --- net/ipv4/tcp_vegas.c | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) aa4db8a59aede2955461910e1516826fd85135a2 diff --git a/net/ipv4/tcp_vegas.c b/net/ipv4/tcp_vegas.c --- a/net/ipv4/tcp_vegas.c +++ b/net/ipv4/tcp_vegas.c @@ -330,6 +330,10 @@ static void tcp_vegas_cong_avoid(struct vegas->cntRTT = 0; vegas->minRTT = 0x7fffffff; } + /* Use normal slow start */ + else if (tp->snd_cwnd <= tp->snd_ssthresh) + tcp_slow_start(tp); + } /* Extract info for Tcp socket info provided via netlink. */ - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html