On Mon, 2005-12-05 at 21:40 -0800, David S. Miller wrote: > From: Tom Young <[EMAIL PROTECTED]> > Date: Tue, 06 Dec 2005 15:38:39 +1100 > > > Do timestamping before cloneing. > > This fixes the bug where the timestamp was performed in tcp_transmit_skb > > on > > the cloned skb leading to the timestamp being lost. > > > > Signed-off-by: Thomas Young <[EMAIL PROTECTED]> > > Excellent catch. > > Why don't we do it in one place, tcp_transmit_skb(), so we don't have > to duplicate this logic in all the call sites? Something like the > patch below. >
That looks like a much cleaner solution to the problem. Though maybe it would be nicer to have a named constant (#define CLONE_SKB 1?) or something similar, rather than the slightly less decriptive 1/0? Thanks, Tom - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
