From: Mike Stroyan <[EMAIL PROTECTED]>
Date: Tue, 29 Nov 2005 14:23:10 -0700

>   The tcp_ehash hash table gets too big on systems with really big memory.
> It is worse on systems with pages larger than 4KB.  It wastes memory that
> could be better used.  It also makes the netstat command slow because reading
> /proc/net/tcp and /proc/net/tcp6 needs to go through the full hash table.

Nobody should be using /proc/net/tcp{,6} for anything.
The netlink based socket dumping is what one should use.

Anyone running a multi-user system should change the file
protections of /proc/net/tcp{,6} so that normal users cannot
access those files if they think this is an issue.

This does not detract from your fix, however :)

I agree that a connection between PAGE_SHIFT and hash sizing
is pointless.  Actually, it's more important to have a tie between
"pointer size" and hash sizing, ie. 64-bit systems should apportion
twice as much space for TCP hash tables as 32-bit systems.
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to