On Tue, Nov 22, 2005 at 12:20:30AM +0100, Richard Knutsson wrote: > > Am thinking of removing the #ifdef CONFIG_PCI's in other files, to > "clean up" the code, but that would introduce this problem again, don't > you think it is more readable to make an empty struct when !CONFIG_PCI, > then making new pci_*-functions specific to the driver?
I think my version is more readable. However, it's really up to Jeff to decide. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} <[EMAIL PROTECTED]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html