jamal <[EMAIL PROTECTED]> writes: > My suggestion is at this point to ignore any L3 issues and have people > post their patches. RFC 2863 states MUST be taken into consideration. > Proper naming must be taken into account.
I'll not repost my patch because you already have it and it lacks only cosmetic things for now (like missing ending comma in flag list for nice future diff outputs) but a little thing about names: "Dormant" is not a flag (1 bit) but rather a specific set of flags (exactly as there is no "running" nor "l2down" bits). So set_dormant*() (with bit flags) doesn't make much sense unless it changes multiple flags which would be crazy. get_dormant() - if needed - does make sense, though. I.e., down = 1 <=> admin = 0 l2down = 1 <=> admin = 1 & carrier = 0 dormant = 1 <=> admin = 1 & carrier = 1 & protocol = 0 running = 1 <=> admin = 1 & carrier = 1 & protocol = 1 That is how I think we should derive SNMP states from bit flags. We could extend it later to include things like dormant-l3up (if really needed, I doubt it). The above table is complete, it covers all possible flag combinations and it should stay that way if a new flag is added. Of course if we go with "enum" this all doesn't matter: we would have down (admin down), l2down, dormant and running as separate values, with no "protocol" nor "carrier" names. -- Krzysztof Halasa - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
