On Sat, Nov 12, 2005 at 10:52:13AM +0100, Christoph Hellwig wrote: > ppp ioctls handlers in parisc are wrong: > > - they would need to do a copat_ptr on ifr->ifr_ifru.ifru_data > - SIOCGPPP* ioctls are defines as SIOCDEVPRIVATE + n, so they'd > kick in for all private ioctls which is defintely wrong. > > to implement proper ppp compat_ioctl handlig we'd need a compat_ioctl > method in struct net_device, which we don't have yet.
While I agree that this is theoretically wrong, the problem is that if we remove them, people using ppp on 64-bit PA machines will no longer be able to do so. And yes, there are some, that's why these got added in the first place. Perhaps I'll look into the compat_ioctl route later. In any case, I would prefer this patch not be added for the moment. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
