The patch below fixes a minor issue with inet6_init.
I noticed though that the code explicitly ignores
the error code of sock_register by calling:
        (void) sock_register(&inet6_family_ops);
Why does it do this?

Olaf
------------------------------------------------------------------
Subject: inet6_init: cleanup after failed initialization

  When initialization fails in inet6_init(), we should
  unregister the PF_INET6 socket ops.

  Signed-off-by: Olaf Kirch <[EMAIL PROTECTED]>

Index: linux-2.6.14/net/ipv6/af_inet6.c
===================================================================
--- linux-2.6.14.orig/net/ipv6/af_inet6.c
+++ linux-2.6.14/net/ipv6/af_inet6.c
@@ -797,6 +797,7 @@ icmp_fail:
 #endif
        cleanup_ipv6_mibs();
 out_unregister_raw_proto:
+       sock_unregister(PF_INET6);
        proto_unregister(&rawv6_prot);
 out_unregister_udp_proto:
        proto_unregister(&udpv6_prot);

-- 
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
[EMAIL PROTECTED] |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to