On Tue, 30 Aug 2005 14:30:16 +0800, Zhu Yi wrote:
> Boardcast address should also be detected by is_multicast_ether_addr().
> Otherwise is_valid_ether_addr() is broken.
Please, add a comment to is_multicast_ether_addr() stating that
broadcast is a special case of multicast.
Otherwise one can be trapped with something like this:
if (is_multicast_ether_addr(addr)) {
...
} else if (is_broadcast_ether_addr(addr)) {
...
}
Thanks,
--
Jiri Benc
SUSE Labs
-
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
