From: Patrick McHardy <[EMAIL PROTECTED]> Subject: Re: [patch 4/7] [IPV4]: Move ip options parsing out of ip_rcv_finish() Date: Sat, 20 Aug 2005 03:53:01 +0200
> Thomas Graf wrote: > > Signed-off-by: Thomas Graf <[EMAIL PROTECTED]> > > > > Index: net-2.6.14/net/ipv4/ip_input.c > > =================================================================== > > --- net-2.6.14.orig/net/ipv4/ip_input.c > > +++ net-2.6.14/net/ipv4/ip_input.c > > @@ -279,6 +279,58 @@ int ip_local_deliver(struct sk_buff *skb > > ip_local_deliver_finish); > > } > > > > +static inline int ip_rcv_options(struct sk_buff *skb) > > How about uninlining this? Options are rare and options parsing > is rather expensive anyway. If the function is expanded into only one place, it doesn't matter either way, and actually inlining is preferable because the compiler can make certain simplifications at compile time. - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
