On Thu, Jul 28, 2005 at 12:38:53PM -0700, David S. Miller wrote: > From: "John W. Linville" <[EMAIL PROTECTED]> > Date: Thu, 28 Jul 2005 10:56:20 -0400 > > > I wonder how many files include ethtool.h w/o including netdevice.h...? > > This makes userspace inclusion a pain, in fact I bet adding > the linux/netdevice.h include will break the build for > somebody. Good point. I neglected the userland component of ethtool... :-(
> And what if we want to extend MAX_ADDR_LEN some day? > > Probably it is better to define the ethtool object returned to the > user as some kind of TLV, so the size doesn't matter. Can you point Jon at a good example of this? John -- John W. Linville [EMAIL PROTECTED] - To unsubscribe from this list: send the line "unsubscribe netdev" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html
